ci: cache odyssey build on e2e #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
force-pushed
the
joshie/cache
branch
from
302f270 to
6e8d67b
Compare
onbjerg
reviewed
Nov 26, 2024
| - name: Build Odyssey | ||
| run: docker buildx build . --load -t ghcr.io/ithacaxyz/odyssey:latest | ||
| run: | | ||
| cargo build --profile release --locked --bin odyssey && |
Contributor
There was a problem hiding this comment.
Can u explain why we need to build here as well?
Contributor
Author
There was a problem hiding this comment.
docker build is not using the rust-cache, and so, we end up downloading/compiling all dependencies in every run. By building it outside we can leverage rust-cache, and then just use a minimal Dockerfile to copy the built binary
we do something similar to this on reth:
onbjerg
reviewed
Nov 26, 2024
| @@ -0,0 +1,13 @@ | |||
| FROM ubuntu | |||
Contributor
There was a problem hiding this comment.
why do we need this file as well?
onbjerg
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.