Skip to content

Clarify ServiceScopeConfig API #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify ServiceScopeConfig API #3518

wants to merge 1 commit into from
+44 −24

Conversation

jaellio
Copy link
Contributor

@jaellio jaellio commented Jun 9, 2025 •
edited
Loading

Fixes typos and clarifies behavior of namespace and service selectors.

  • Compatibility with ServiceEntry is not in scope for the alpha ambient mode multicluster implementation. More documentation will follow in later versions.

@jaellio
Clarify ServiceScopeConfig API
1f2a27b 
Fixes typos and clarifies behavior of namespace and service
selectors.

Signed-off-by: Jackie Elliott <[email protected]>
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 9, 2025
@istio-policy-bot
Copy link

😊 Welcome @jaellio! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2025
@jaellio jaellio marked this pull request as ready for review June 9, 2025 23:01
@jaellio jaellio requested a review from a team as a code owner June 9, 2025 23:01
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 9, 2025
@istio-testing
Copy link
Collaborator

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api 1f2a27b link false /test release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio jaellio added the release-notes-none Indicates a PR that does not require release notes. label Jun 10, 2025
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 17, 2025
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaellio @istio-testing @istio-policy-bot