-
Notifications
You must be signed in to change notification settings - Fork 53
Update Ztunnel config CRD flags #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxBab
wants to merge
1
commit into
istio-ecosystem:main
Choose a base branch
from
MaxBab:update_ztunnel_config_crd_flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,8 @@ type ZTunnelConfig struct { | |
// Image name to pull from. Image will be `Hub/Image:Tag-Variant`. | ||
// If Image contains a "/", it will replace the entire `image` in the pod. | ||
Image *string `json:"image,omitempty"` | ||
// We keep the global namespace around for backward-compatibility | ||
Global map[string]string `json:"global,omitempty"` | ||
// resourceName, if set, will override the naming of resources. If not set, will default to the release name. | ||
// It is recommended to not set this; this is primarily for backwards compatibility. | ||
ResourceName *string `json:"resourceName,omitempty"` | ||
|
@@ -60,12 +62,16 @@ type ZTunnelConfig struct { | |
VolumeMounts []k8sv1.VolumeMount `json:"volumeMounts,omitempty"` | ||
// Additional volumes to add to the ztunnel Pod. | ||
Volumes []k8sv1.Volume `json:"volumes,omitempty"` | ||
// Tolerations for the ztunnel pod | ||
Tolerations []k8sv1.Toleration `json:"tolerations,omitempty"` | ||
// Annotations added to each pod. The default annotations are required for scraping prometheus (in most environments). | ||
PodAnnotations map[string]string `json:"podAnnotations,omitempty"` | ||
// Additional labels to apply on the pod level. | ||
PodLabels map[string]string `json:"podLabels,omitempty"` | ||
// The k8s resource requests and limits for the ztunnel Pods. | ||
Resources *k8sv1.ResourceRequirements `json:"resources,omitempty"` | ||
// The resource quotas configuration for ztunnel | ||
ResourceQuotas *ResourceQuotas `json:"resourceQuotas,omitempty"` | ||
// List of secret names to add to the service account as image pull secrets | ||
// to use for pulling any images in pods that reference this ServiceAccount. | ||
// Must be set for any cluster configured with private docker registry. | ||
|
@@ -105,6 +111,11 @@ type ZTunnelConfig struct { | |
LogLevel *string `json:"logLevel,omitempty"` | ||
// Specifies whether istio components should output logs in json format by adding --log_as_json argument to each container. | ||
LogAsJSON *bool `json:"logAsJson,omitempty"` | ||
// Set seLinux options for the ztunnel pod | ||
SeLinuxOptions map[string]string `json:"seLinuxOptions,omitempty"` | ||
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this also won't work. |
||
// K8s DaemonSet update strategy | ||
// https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec). | ||
UpdateStrategy *IstioUpdateStrategy `json:"updateStrategy,omitempty"` | ||
} | ||
|
||
// ZTunnelGlobalConfig is a subset of the Global Configuration used in the Istio ztunnel chart. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? In any case, I think map[string]string is not the right type. It won't support nested fields