-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix tensor reconstruction example #6207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
Update - I have tested the changes and docs are fine. Note - I have not changed documentation of
|
|
Update - Just noticed my mistake. I forgot to set |
4aa129d to
cad75ee
Compare
theNded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will also work on improving it.
|
@ssheorey It is ready to merge, my follow-up upgrades will be in separate PRs. |
|
Thanks @saurabheights ! |
Type
Motivation and Context
The
integrate.pyinexamples/python/t_reconstructiondid not work. I am using open3d v0.17.0 with python 3.10.10 on ubuntu 22.04.store_trueno longer works, see here. ~~ MY BAD - This is not a bug.integration_modewhich can be removed in favor ofintegrate_colorwhich is IMO easy to understand.integrate_coloris method argument here but missing in callerChecklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This change is