do not allow .. to walk up out of a Windows root - #319
Open
lazerg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows a
..in a pattern walks straight out of the root, soC:/../xcollapses toxand//srv/share/../xturns into//srv/x. The guard from 7953af1 sits inlevelTwoFileOptimize, which only runs on the file being matched, so the pattern side (firstPhasePreProcessat level 2,levelOneOptimizeat level 1) was never guarded, and UNC roots weren't covered anywhere.isWindowsRoot()now does that check in all three..loops, and a..landing on a root is dropped rather than consuming the root. Level 1 is the default, so this changes default behavior on Windows too.Fixes #318