fix: [:print:] class matches printable characters, not control - #309
Open
mahirhir wants to merge 1 commit into
Open
fix: [:print:] class matches printable characters, not control#309mahirhir wants to merge 1 commit into
mahirhir wants to merge 1 commit into
Conversation
The [:print:] POSIX class was translated to `[\p{C}]`, which matches
control characters and never matches printable ones, so a pattern like
`[[:print:]]` failed to match `a` and matched `\x01` instead.
Negate it to `[^\p{C}]`, mirroring the sibling [:graph:] class, so it
matches every character except control characters (space included).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[:print:]POSIX character class is translated to[\p{C}], the set of control characters. Without a negation flag it matches control characters and never matches printable ones, so the result is inverted:[:print:]should match every printable character, i.e. everything except control characters, including the space. The sibling[:graph:]class uses the same\p{C}exclusion and is already negated correctly (['\\p{Z}\\p{C}', true, true]);[:print:]is the only class that takes the\p{C}exclusion approach but is missing the negation flag.The fix adds the flag so
[:print:]becomes[^\p{C}]:Added
test/posix-class-print.ts. It fails on the current code (the printable assertions return false) and passes with the change. The full suite stays green; no existing tests or snapshots reference[:print:].