Enhance Binding process #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
adracus
force-pushed
the
feature/enhance-binding
branch
2 times, most recently
from
3af22c0 to
1e563da
Compare
Remove `Phase` attributes from volumes, network interfaces, networks etc. and simplify binding to be done by the 'executing' controller (e.g. `NetworkInterface` controller tries to set `targetRef` on a `VirtualIP`). Update related code in machinepoollet and controllers. Update test cases.
adracus
force-pushed
the
feature/enhance-binding
branch
from
1e563da to
95382b4
Compare
lukasfrank
reviewed
Aug 1, 2023
lukasfrank
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Phaseattributes from volumes, network interfaces, networks etc. and simplify binding to be done by the 'executing' controller (e.g.NetworkInterfacecontroller tries to settargetRefon aVirtualIP).Update related code in machinepoollet and controllers.
Update test cases.