Add NetworkInterface type
#348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api-change
compute
enhancement
afritzler
force-pushed
the
feature/networkinterface
branch
4 times, most recently
from
3da8dbd to
f2eae39
Compare
afritzler
force-pushed
the
feature/networkinterface
branch
from
5039285 to
dfa1e86
Compare
afritzler
commented
Apr 21, 2022
adracus
reviewed
Apr 21, 2022
Contributor
adracus
left a comment
adracus
left a comment
There was a problem hiding this comment.
Some more or less minor nits.
adracus
approved these changes
Apr 22, 2022
adracus
force-pushed
the
feature/networkinterface
branch
from
48fbad8 to
eef9659
Compare
adracus
force-pushed
the
feature/networkinterface
branch
from
eef9659 to
965c4f3
Compare
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
NetworkInterfacetype.NetworkInterfacein storage and registry/ref onmetal/onmetal-api#334