Remove scoped reference #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XXL
api-change
compute
core
enhancement
All commonv1alpha1.ScopedReferences are removed in favor of simple corev1.LocalObjectReferences. Additionally, the manager overlay is removed as relation computation w/o the refs does not make that much sense anymore. Also, dependency and dependant triggering via watches and field indexers is the proper way how it is built into any controller using the controller-runtime and makes us behave more in line / not having to maintain additional overlays.
adracus
force-pushed
the
feature/remove-scoped-ref
branch
from
2e20d46 to
a81cf44
Compare
afritzler
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
All commonv1alpha1.ScopedReferences are removed in favor of simple
corev1.LocalObjectReferences.
Additionally, the manager overlay is
removed as relation computation w/o the refs does not make that much
sense anymore.
Also, dependency and dependant triggering via watches and field indexers
is the proper way how it is built into any controller using the
controller-runtime and makes us behave more in line / not having to
maintain additional overlays.