Implement ssh key controller #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XL
api-change
compute
core
enhancement
Member
|
Two small things. Maybe we should put the |
Member
|
Could you also update the sample CR in the |
Update condition library to support setting observed generation on any condition. Augment `SSHPublicKey` spec to use config maps as default sources for the public key data. Create test cases for the new controller.
adracus
force-pushed
the
feature/ssh-key-controller
branch
from
45982e7 to
f3ec68f
Compare
Contributor
Author
|
@afritzler implemented your suggestions, should be up to date now. |
afritzler
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update condition library to support setting observed generation on any
condition.
Augment
SSHPublicKeyspec to use config maps as default sources forthe public key data.
Create test cases for the new controller.