Remove downward-api label filtering dependency
#1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasfrank
requested changes
Aug 21, 2025
opensovereigncloud-user
force-pushed
the
osc/fix/remove-downwardapi-label-dependency
branch
from
5f801fa to
ccc4648
Compare
lukasfrank
reviewed
Aug 29, 2025
lukasfrank
changed the title
downward-api label filtering dependency
lukasfrank
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
machinepoolletto list and delete machines usingmachinepoollet.ironcore.dev/machine-uidlabelListMachinesby handling it unifiedmachinebrokerto addmachinepoollet.ironcore.dev/machine-uidlabel with parent machine uid as value inCreateMachinefunction1to0Fixes #1339