Skip to content

Add the brokered downward-api NIC Labels in the machine aggregator #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 3 commits into from
Aug 11, 2025
Merged

Add the brokered downward-api NIC Labels in the machine aggregator #1355

lukasfrank merged 3 commits into from
Aug 11, 2025

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Aug 6, 2025

Proposed Changes

  • Add the brokered downward-api NIC Labels in the machine aggregator into the broker's machine.go
  • Add only downward-api labels and remove other labels for NetworkInterface resource
  • Keep the downward-api flag name consistent for Volume and Bucket, similar to Machine

Fixes: ref/#1316

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner August 6, 2025 09:12
@github-actions github-actions bot added enhancement New feature or request size/S labels Aug 6, 2025
@Rohit-0505 Rohit-0505 marked this pull request as draft August 6, 2025 09:18
balpert89
balpert89 approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@balpert89 balpert89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested in our lab, brokering works as expected now with the labels on the derived resources. No continuously re-created network interfaces anymore.

@balpert89 balpert89 marked this pull request as ready for review August 6, 2025 09:47
@Rohit-0505 Rohit-0505 self-assigned this Aug 6, 2025
afritzler
afritzler approved these changes Aug 6, 2025
View reviewed changes
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Aug 7, 2025
@hardikdr hardikdr added this to Roadmap Aug 7, 2025
@lukasfrank lukasfrank merged commit 3886b46 into ironcore-dev:main Aug 11, 2025
12 of 13 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balpert89 balpert89 balpert89 approved these changes

@afritzler afritzler afritzler approved these changes

@lukasfrank lukasfrank lukasfrank approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. enhancement New feature or request size/S

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rohit-0505 @afritzler @lukasfrank @balpert89 @hardikdr