Add downwardAPILabel support for Network and updated for NetworkInterface resource
#1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
from
030febb to
cc55eb8
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
from
cc55eb8 to
5a33e0c
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
2 times, most recently
from
59108d9 to
4177ab0
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
3 times, most recently
from
b81269c to
6f5d001
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
2 times, most recently
from
21c9f33 to
bdc42e7
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
2 times, most recently
from
ca6b233 to
23e6e12
Compare
balpert89
requested changes
Aug 22, 2025
poollet/machinepoollet/controllers/machine_controller_networkinterface.go
Outdated
Show resolved
Hide resolved
kasabe28
reviewed
Aug 22, 2025
poollet/machinepoollet/controllers/machine_controller_networkinterface.go
Outdated
Show resolved
Hide resolved
lukasfrank
requested changes
Aug 22, 2025
poollet/machinepoollet/controllers/machine_controller_networkinterface.go
Outdated
Show resolved
Hide resolved
opensovereigncloud-user
force-pushed
the
osc/enh/network-downward-api-labels-support
branch
from
dd4bc33 to
cfdfc16
Compare
lukasfrank
requested changes
Aug 27, 2025
lukasfrank
approved these changes
Aug 28, 2025
Rohit-0505
changed the title
downwardAPILabel support for Network resourcedownwardAPILabel support for Network and updated for NetworkInterface resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Labels,NetworkLabelsfrom machineapi.protoand reuseAttributesfield to transport DownwardAPILabels forNetworkandNICresources, This approach ensures generic behavior untouched at all layersdownward-apilabels support forNetworkresourcemanager.yamlwith downward-api-label argsFix: Add downward-api label support to other resources similar to machine #1316