Skip to content

Introduce separate flags for NIC resource to support DownwardAPILabels propagation #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afritzler merged 1 commit into from
Jul 30, 2025
Merged

Introduce separate flags for NIC resource to support DownwardAPILabels propagation #1346

afritzler merged 1 commit into from
Jul 30, 2025

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Jul 29, 2025

Proposed Changes

  • Introduce new flags NicDownwardAPILabels and NicDownwardAPIAnnotations for NIC resource
  • Make other necessary changes
  • Update the test suites

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner July 29, 2025 04:24
@github-actions github-actions bot added size/M enhancement New feature or request labels Jul 29, 2025
@Rohit-0505 Rohit-0505 changed the title introduce seperate flags for NIC resource to support downwardAPILabels propagation introduce seperate flags for NIC resource to support DownwardAPILabels propagation Jul 29, 2025
@Rohit-0505 Rohit-0505 changed the title introduce seperate flags for NIC resource to support DownwardAPILabels propagation Introduce separate flags for NIC resource to support DownwardAPILabels propagation Jul 29, 2025
@Rohit-0505 Rohit-0505 self-assigned this Jul 29, 2025
@Rohit-0505 Rohit-0505 mentioned this pull request Jul 29, 2025
Merged
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jul 29, 2025
@hardikdr hardikdr added this to Roadmap Jul 29, 2025
balpert89
balpert89 approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@balpert89 balpert89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afritzler afritzler merged commit 11b3f21 into ironcore-dev:main Jul 30, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

@balpert89 balpert89 balpert89 approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. enhancement New feature or request size/M

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rohit-0505 @afritzler @balpert89 @hardikdr