Skip to content

Remove redundant VirtualIP test case #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 1 commit into from
Jul 22, 2025
Merged

Remove redundant VirtualIP test case #1336

lukasfrank merged 1 commit into from
Jul 22, 2025

Conversation

@ushabelgur
Copy link
Contributor

@ushabelgur ushabelgur commented Jul 21, 2025

Proposed Changes

  • If VirtualIP is unmanaged, it will be deleted in either of the cases even when we set controllerRef or ephemerallyManaged annotation.
  • Removing this flaky TC as the case is already covered in previous TC.

Fixes #1323

@ushabelgur ushabelgur requested a review from a team as a code owner July 21, 2025 08:31
@github-actions github-actions bot added size/M bug Something isn't working labels Jul 21, 2025
@ushabelgur ushabelgur requested a review from afritzler July 21, 2025 09:39
@Rohit-0505 Rohit-0505 changed the title Remove unwanted tesc case Remove unwanted test case Jul 21, 2025
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jul 22, 2025
@hardikdr hardikdr added this to Roadmap Jul 22, 2025
@lukasfrank lukasfrank changed the title Remove unwanted test case Remove redundant VirtualIP test case Jul 22, 2025
@lukasfrank lukasfrank merged commit c26bfe3 into ironcore-dev:main Jul 22, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@afritzler afritzler Awaiting requested review from afritzler

Assignees

No one assigned

Labels

area/iaas Issues related to IronCore IaaS development. bug Something isn't working size/M

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky tests

3 participants

@ushabelgur @lukasfrank @hardikdr