Skip to content

Introduce ReclaimPolicy for ephemeral VirtualIP #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afritzler merged 4 commits into from
Apr 4, 2025
Merged

Introduce ReclaimPolicy for ephemeral VirtualIP #1222

afritzler merged 4 commits into from
Apr 4, 2025

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Jan 21, 2025 •
edited by afritzler
Loading

Proposed Changes

  • Add ReclaimPolicy for ephemerally created virtualIP resource with below supported modes:
    • Retain: the resource is not deleted after the managing resource has been deleted
    • Delete: the current behavior, the resource is garbage-collected when the managing resource has been deleted
  • The default ReclaimPolicy is considered implicit Delete to avoid breaking current behavior.
  • Add wrapper type for VirtualIPTemplateSpec to support ReclaimPolicy type along with existing VirtualIPSpec
  • OwnerReference is set to an ephemerally created virtualIP with ReclaimPolicyTypeDelete.
  • To prevent deletion of ephemeral vip without ownerReference a RESTDeleteStrategy method ValidateDelete is added in the strategy.go
  • Add Test cases
    [Note: virtualIP_release_controller is already taking care of releasing virtualIP whose claimer doesn't exist, by setting .spec.targetRef to nil when claimer NetworkInterface object is deleted. So not adding any extra logic for this]

Fixes #1115

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner January 21, 2025 08:17
@lukas016 lukas016 force-pushed the osc/enh-ephemeral-vip-reclaim branch 2 times, most recently from ac02826 to 39cc4d4 Compare January 21, 2025 08:58
@Rohit-0505 Rohit-0505 self-assigned this Jan 21, 2025
@afritzler afritzler changed the title Introduce ReclaimPolicy for ephemeral virtualIP Introduce ReclaimPolicy for ephemeral VirtualIP Jan 23, 2025
afritzler
afritzler requested changes Apr 3, 2025
View reviewed changes
@github-actions github-actions bot added size/XL documentation Improvements or additions to documentation and removed size/L labels Apr 4, 2025
@lukas016 lukas016 force-pushed the osc/enh-ephemeral-vip-reclaim branch from 2f03442 to 0b111b3 Compare April 4, 2025 06:15
@afritzler afritzler added the enhancement New feature or request label Apr 4, 2025
@lukas016 lukas016 force-pushed the osc/enh-ephemeral-vip-reclaim branch from 0b111b3 to 6a1fcd2 Compare April 4, 2025 06:50
@afritzler afritzler merged commit afcbfd0 into ironcore-dev:main Apr 4, 2025
14 checks passed
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jun 26, 2025
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. documentation Improvements or additions to documentation enhancement New feature or request size/XL

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce a reclaim policy for ephemerally created Virtual IP resources

4 participants

@Rohit-0505 @afritzler @hardikdr @ushabelgur