Implemented a split client for *-brokers
#1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas016
force-pushed
the
osc/feat/split-client
branch
4 times, most recently
from
3ee1313 to
1a2aef0
Compare
lukasfrank
reviewed
Dec 3, 2024
lukasfrank
approved these changes
Dec 4, 2024
lukasfrank
changed the title
*-brokers
Member
|
@balpert89 can you please rebase the PR branch? |
lukas016
force-pushed
the
osc/feat/split-client
branch
from
f5c739b to
521edc7
Compare
Contributor
Author
done. |
lukas016
force-pushed
the
osc/feat/split-client
branch
from
94b370a to
387ee59
Compare
… brokers. - Pass context (`ctx`) to server creation functions for better resource management. - Implement an in-memory cache with namespace-specific watching for improved performance. - Reorganize imports for readability.
lukas016
force-pushed
the
osc/feat/split-client
branch
from
387ee59 to
7abdf08
Compare
afritzler
requested changes
Dec 16, 2024
| readCache, err := cache.New(cfg, cache.Options{ | ||
| Scheme: scheme, | ||
| DefaultNamespaces: map[string]cache.Config{ | ||
| namespace: {}, |
Member
There was a problem hiding this comment.
Should the namespace be used in the cache setup here?
afritzler
added a commit
that referenced
this pull request
Apr 2, 2025
balpert89
added a commit
that referenced
this pull request
Apr 23, 2025
opensovereigncloud-user
pushed a commit
to opensovereigncloud/ironcore
that referenced
this pull request
May 20, 2025
opensovereigncloud-user
pushed a commit
to opensovereigncloud/ironcore
that referenced
this pull request
May 20, 2025
…" (ironcore-dev#1267) This reverts commit ce56e39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ctx) to server creation functions for better resource management.Fixes #1156