Skip to content

Add e2e IPAM example manifests for IPv4 and IPv6 #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afritzler merged 3 commits into from
Nov 13, 2024
Merged

Add e2e IPAM example manifests for IPv4 and IPv6 #1145

afritzler merged 3 commits into from
Nov 13, 2024

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Oct 29, 2024

  • Add IPAM example manifests for IP allocation to subnets of type IPv4
  • Add IPAM example manifests for IP allocation to subnets of type IPv6

/ref #1129

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner October 29, 2024 07:19
@github-actions github-actions bot added size/L documentation Improvements or additions to documentation enhancement New feature or request labels Oct 29, 2024
@Rohit-0505 Rohit-0505 self-assigned this Oct 29, 2024
@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-ipam-example branch from 4ea387d to 0dcc797 Compare October 31, 2024 06:54
afritzler
afritzler requested changes Nov 4, 2024
View reviewed changes
@github-actions github-actions bot added size/M and removed size/L labels Nov 4, 2024
@Rohit-0505 Rohit-0505 force-pushed the enh/e2e-ipam-example branch from 2ac07c4 to 5aea20e Compare November 6, 2024 05:38
afritzler
afritzler requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove example from the folder name and just use ipam-ipv4 and ipam-ipv6?

@github-actions github-actions bot added size/L and removed size/M labels Nov 11, 2024
@github-actions github-actions bot added size/M and removed size/L labels Nov 11, 2024
@afritzler afritzler merged commit 6a612a0 into main Nov 13, 2024
13 checks passed
@afritzler afritzler deleted the enh/e2e-ipam-example branch November 13, 2024 08:51
balpert89 pushed a commit that referenced this pull request Apr 23, 2025
@Rohit-0505 @balpert89
Add e2e IPAM example manifests for IPv4 and IPv6 (#1145)
07aad4e 
* Add e2e `IPAM` example manifests for `IPv4` and `IPv6`

* address review comments

* address review comment
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jun 26, 2025
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. documentation Improvements or additions to documentation enhancement New feature or request size/M

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rohit-0505 @afritzler @hardikdr