Skip to content

Extend Volume Runtime Interface for cross-cluster Events #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 2 commits into from
Jul 24, 2024
Merged

Extend Volume Runtime Interface for cross-cluster Events #1092

lukasfrank merged 2 commits into from
Jul 24, 2024

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Jul 19, 2024 •
edited
Loading

Proposed Changes

  • Extend volume runtime interface to support ListEvents method
  • Add VolumeEventMapper for periodic relisting and recording of volume events
  • Add RBAC rules for volume-broker events
  • Add corresponding tests
  • Add missing tests for volume-broker
  • Extend irictl-volume with get events command

Fixes #1070

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner July 19, 2024 07:54
@github-actions github-actions bot added enhancement New feature or request size/XXL labels Jul 19, 2024
@Rohit-0505 Rohit-0505 marked this pull request as draft July 19, 2024 08:01
@Rohit-0505 Rohit-0505 self-assigned this Jul 19, 2024
@Rohit-0505 Rohit-0505 marked this pull request as ready for review July 19, 2024 08:17
lukasfrank
lukasfrank reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you maybe also add the changes from here #1093 once we merged it?

@lukasfrank lukasfrank merged commit c2f923e into main Jul 24, 2024
@lukasfrank lukasfrank deleted the enh/volume-events branch July 24, 2024 06:16
sujeet01 pushed a commit that referenced this pull request Jul 24, 2024
@Rohit-0505 @sujeet01
Extend Volume Runtime Interface for cross-cluster Events (#1092)
fdc8df0
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jun 26, 2025
@hardikdr hardikdr added this to Roadmap Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@afritzler afritzler Awaiting requested review from afritzler

Assignees

@Rohit-0505 Rohit-0505

Labels

area/iaas Issues related to IronCore IaaS development. enhancement New feature or request size/XXL

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend Runtime Interface to Support Cross-Cluster Events

4 participants

@Rohit-0505 @lukasfrank @hardikdr