[Codegen] Avoid unnecessary masking in map_scatter #22959
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When folding
extract_sliceoperations intomap_scatter, the current behavior is always adding masking logic, without checking whether theextract_sliceis an identity. For static shapes, this is fine because later optimizations will remove the unnecessary masking. However, for dynamic shapes, the masking code persists and adds runtime overhead. This PR therefore avoids inserting unnecessary masking at the first place.This PR also changes the behavior of pure-tensor, identity
map_scattercanonicalization from being replaced with acopyoperation to simply erased. The previous use ofcopyoperations was causing issues withLLVMGPUSelectLoweringStrategyPass.This PR helps mitigate the VGPR spilling issue observed in #21865.
Depends on llvm/llvm-project#173356.