Extract the Comm Python package#973
Merged
blink1073 merged 2 commits intoipython:mainfrom Nov 18, 2022
Merged
Conversation
da6e9ec to
aeaaf80
Compare
0fe77b6 to
a9556dd
Compare
blink1073
reviewed
Nov 17, 2022
f60a46f to
48524de
Compare
for more information, see https://pre-commit.ci
50e9e54 to
b11a831
Compare
Contributor
Author
|
I marked the PR as ready to review! I might be wrong but the ipyparallel issue seems unrelated? |
Contributor
Correct |
Contributor
|
I'll cut a minor release with this change early next week. |
Member
|
@blink1073, is there full compatibility for projects that import the |
Contributor
|
Yes, the equivalent classes are exported from the |
Contributor
|
This broke compatibility in Solara, since I was doing Giving me: Not sure if this should be considered a public API (the constructor), if so, happy to open an issue. |
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Nov 21, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Nov 21, 2022
Contributor
|
@martinRenou really nice to see this out this soon btw :) congrats |
Contributor
|
I think the cause is the same as #1026 |
This was referenced Nov 29, 2022
blink1073
added a commit
to blink1073/ipykernel
that referenced
this pull request
Dec 7, 2022
This reverts commit 6607b9d.
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently working on a Python comm package on https://github.com/martinRenou/comm for now, but it should probably be moved in the IPython orgThis PR relies on the new comm package https://github.com/ipython/comm
This has the benefit of being able to: