Merged
Conversation
format dates as ISO8601 - currently works for datetimes, but not dates. Follow up to ipython#18
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
blink1073
approved these changes
Dec 14, 2022
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Thank you! I'll handle the lint issue in a follow-up PR, it is unrelated.
Contributor
Author
|
Thanks for the quick response :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format dates as ISO8601 - currently works for datetimes, but not dates.
Follow up to #18
fixes: plotly/plotly.py#3075
labels: enhancement, bug