Fix: there can be only one comm_manager#1049
Merged
blink1073 merged 7 commits intoipython:mainfrom Dec 7, 2022
Merged
Conversation
maartenbreddels
force-pushed
the
fix_comm_manager_singleton
branch
from
d8fdc4b to
5f42999
Compare
Contributor
Author
|
FYI, the problem was there every call to |
for more information, see https://pre-commit.ci
blink1073
changed the title
Contributor
|
Thanks @maartenbreddels! Let's try another release... |
Contributor
Author
|
I’m gonna eat my laptop if the next version needs yanking! |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1043
I've tested this branch with our largest ipywidgets based application (yes it was broken before, I confirmed that, a previous test I did was obviously using the wrong environment).
And now it's working well.
@blink1073 shall I put the test of #1048 on top of this?
cc @martinRenou