Fix cbor cid serde #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
koivunej
commented
Apr 7, 2020
koivunej
commented
Apr 7, 2020
|
LGTM |
vmx
reviewed
Apr 8, 2020
|
I haven't understood the why yet. Is this part of the cbor or the dag cbor spec? Or is this a bug in the go implementation? |
|
@dvc94ch Part of the DagCBOR spec as linked in the source: https://github.com/ipld/specs/blob/51eb2f682f554b726021f34398843f8edf97bbd0/block-layer/codecs/dag-cbor.md#links. The CID is Multibase encoded, hence has a |
|
I'm pretty sure that section was added after implementing this version. We'll have to live with "historical reasons" then... |
|
Now that that convo is resolved, ok to merge @dvc94ch ? |
dvc94ch
approved these changes
Apr 8, 2020
vmx
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zero byte prefix inside the length delimited byte array was not omitted or added.