Skip to content

Bitswap spec update #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2018
Merged

Bitswap spec update #171

merged 3 commits into from
May 12, 2018

Conversation

dgrisham
Copy link
Member

@dgrisham dgrisham commented Dec 13, 2017

Editing and updating the Bitswap spec. Work in progress. Starts from #168

@dgrisham dgrisham force-pushed the bitswap/spec-update branch 2 times, most recently from 8add718 to 3163011 Compare December 13, 2017 19:12
@dgrisham dgrisham force-pushed the bitswap/spec-update branch from 38f1800 to a8fb19f Compare January 8, 2018 18:01
@dgrisham
Copy link
Member Author

dgrisham commented Jan 8, 2018

@diasdavid This is ready for a first-pass review :)

@daviddias
Copy link
Member

Skimmed through it, so far so good :)

@daviddias
Copy link
Member

@dgrisham when will the final version be ready?

@dgrisham
Copy link
Member Author

dgrisham commented Apr 9, 2018

I'll work on getting the Bitswap sessions section together within the next week or so when I have time. That and the API are the most substantial parts left -- is the API far enough along to be set, or should that be left unfinished for now in lieu of future changes?

License: MIT
Signed-off-by: David Grisham <[email protected]>
@dgrisham dgrisham force-pushed the bitswap/spec-update branch from 915f4e7 to b29985d Compare April 16, 2018 17:23
@Stebalien
Copy link
Member

If possible, let's try to keep the pieces separate. There are three parts:

  1. The network protocol. This is the "real" spec, the description of how nodes work together.
  2. Concepts/algorithms (e.g., sessions). Nodes should follow these guidelines but, really, these are just suggestions on how to use the bitswap protocol effectively.
  3. Service API. Is that even part of the spec? I guess it's useful as a "and here's what bitswap is for"...

@daviddias daviddias changed the title WIP: Bitswap spec update Bitswap spec update May 12, 2018
@daviddias
Copy link
Member

sounds good @dgrisham. Let's take it as it is and continue from there.

@daviddias daviddias merged commit 3f21855 into ipfs:master May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants