Error: Not able to stop from state: stopping

[lidel]

• Version: v0.36.4
• Platform: JS
• Subsystem: state machine

Type: Enhancement

Severity: Medium

Steps to reproduce the error:

calling .stop() on a node that is already stopping produces Error: Not able to stop from state: stopping

js-ipfs/src/core/components/stop.js

Lines 16 to 17 in 88f4e26

	if (self.state.state() !== 'running') {
	return callback(new Error('Not able to stop from state: ' + self.state.state()))

Proposed change

.stop() should be idempotent, all subsequent calls should detect stopping and return promise that resolves when stop event is emited by the very first .stop()

Y/n?

cc #1061, #890, ipfs/ipfs-companion#716

[dirkmc]

I agree, we throw errors when stop is called twice in some places in libp2p as well. It makes it complicated when you have multiple ways to stop things, for example:
"shut this thing down if the connection closes or if the user clicks stop or if there is a timeout"

[tapaswenipathak]

Hi @lidel, @dirkmc: Can I work on the ticket?

[lidel]

@tapaswenipathak sorry for late reply: yes, you can give it a try