-
Notifications
You must be signed in to change notification settings - Fork 48
Description
-
Should be
timeout
instead (as per comment here https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r589357353)js-ipfs-bitswap/src/network.js
Lines 165 to 167 in f546e4b
// TODO: Should this be a timeout options insetad ? // @ts-expect-error - 'maxTimeout' does not exist in type maxTimeout: CONSTANTS.providerRequestTimeout, -
equality check on messages seems to have a bug (for more context see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587863878)
js-ipfs-bitswap/src/types/message/index.js
Lines 207 to 209 in f546e4b
// @TODO - Is this a bug ? // @ts-expect-error - isMap equals map values to be objects not numbers !isMapEqual(this.blockPresences, other.blockPresences) -
Want list entries sorting has a bug (See https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587867673)
-
Need to specify want type when adding it to wantlist (see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587865473)