Error: Not able to stop from state: starting

[lidel]

Error caused by transitory state of js-ipfs breaks logic related to initIpfsClient.

Found during tests of #395 while rapidly switching between embedded and external breaks:

Error comes from js-ipfs: src/core/components/stop.js#L17

Perhaps add-on/src/lib/ipfs-client/embedded.js needs something like this?

-  await node.stop()
+  try {
+    await node.stop()
+  } catch (err) {
+    console.warn('[ipfs-companion] Error while stopping embedded js-ipfs node', err)
+  }
node = null

[alanshaw]

This should be fixed by https://github.com/ipfs-shipyard/ipfs-companion/pull/395/files#diff-32e24012b65c18d8aff3153451004bdcR20 when merged

[lidel]

Yup, #395 fixed this 🍰