Missing output from lint command (and possible others)

[victorb]

When adding a new example to js-ipfs-api and running git commit, aegir runs lint and it failed somewhere but not showing any real errors.

Running eslint directly on the newly added code revealed the following error (but not sure if this is the only/right one)

➜  js-ipfs-api git:(master) ✗ ./node_modules/.bin/eslint -c node_modules/aegir/config/eslintrc.yml examples 

Oops! Something went wrong! :(

ESLint couldn't find the plugin "eslint-plugin-react". This can happen for a couple different reasons:

1. If ESLint is installed globally, then make sure eslint-plugin-react is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.

2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm i eslint-plugin-react@latest --save-dev

If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

[daviddias]

Having a similar problem right now, it is just giving up without telling me anything. (in js-ipfs)

[dignifiedquire]

Details about this: ipfs/js-ipfs#625 (comment)

[victorb]

Could be about this part? https://github.com/dignifiedquire/aegir/blob/5d5e183a8d869231eaab6a4df53d4922fb00b38d/src/gulp-log.js#L33-L35

Would expect us to collect errors if there is a error happening. Not sure, just throwing it out there.

[dignifiedquire]

It has to do with that, but this will also be called with things from gulp we don't want to throw to the user. This code is a 1:1 copy from the original source code of gulp, so it's a deeper problem of orchestrator (scheduling lib that does the heavy lifting for gulp) and gulp