chore(lints): Use expect over allow #4402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
requested review from
a team,
kodemartin and
miker83z
as code owners
iota-ci
added
dev-tools
Thoralf-M
reviewed
Dec 10, 2024
Thoralf-M
reviewed
Dec 10, 2024
Thoralf-M
reviewed
Dec 10, 2024
Thoralf-M
approved these changes
Dec 10, 2024
jkrvivian
approved these changes
Dec 11, 2024
tomxey
approved these changes
Dec 11, 2024
miker83z
approved these changes
Dec 11, 2024
valeriyr
approved these changes
Dec 11, 2024
lucas-tortora
approved these changes
Dec 11, 2024
|
There is a warning if you run clippy in release mode (ignore the external-crates ones). |
DaughterOfMars
changed the title
thibault-martinez
approved these changes
Dec 12, 2024
polinikita
approved these changes
Dec 16, 2024
miker83z
pushed a commit
that referenced
this pull request
Dec 20, 2024
* chore(clippy): Use expect over allow * add comment * fix release warning * revert type complexity allow * review * revert trait config * another revert --------- Co-authored-by: Thibault Martinez <[email protected]>
jkrvivian
pushed a commit
that referenced
this pull request
Jan 6, 2025
* chore(clippy): Use expect over allow * add comment * fix release warning * revert type complexity allow * review * revert trait config * another revert --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Use
expectoverallow, remove unnecessary allows, and fix some that can be easily fixed.Links to any relevant issues
Closes #4204