fix: Fix value for backup unit 'login' attribute#911
Merged
adeatcu-ionos merged 1 commit intomasterfrom Dec 5, 2025
Merged
Conversation
adeatcu-ionos
requested review from
a team,
avirtopeanu-ionos,
cbeti-ionos,
Copilot,
cristiGuranIonos,
glimberea,
mimihalescu and
rmocanu-ionos
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the format of the login attribute value for the backup unit resource by swapping the order of contract number and backup unit name, and adds a null safety check. The fix addresses issue #898 where the login format was incorrect.
Key changes:
- Corrected login format from
{name}-{contract_number}to{contract_number}-{name} - Added null safety check for Properties field before accessing ContractNumber
- Added test validation to ensure login attribute is set
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ionoscloud/resource_backup_unit.go | Fixed login value format and added null safety check for Properties |
| ionoscloud/resource_backup_unit_test.go | Added test assertion to verify login attribute is set |
| CHANGELOG.md | Documented the login value computation fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adeatcu-ionos
force-pushed
the
fix-computed-value-backup-unit-login
branch
from
ea6c0c6 to
e04657d
Compare
adeatcu-ionos
force-pushed
the
fix-computed-value-backup-unit-login
branch
from
e04657d to
ab08404
Compare
|
Member
|
hopefully no one relies on the old format |
cristiGuranIonos
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Fixes #898
Checklist
feat:/fix:/doc:/test:/refactor:)