fix: Fix boot device selection crash#887
Merged
adeatcu-ionos merged 1 commit intomasterfrom Oct 29, 2025
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the boot device selection functionality by properly initializing error sentinel values. The issue occurred because ErrServerNotFound was nil, preventing proper error handling when a server didn't exist.
Key Changes:
- Initialized
ErrServerNotFoundandErrSuspendCubeLastsentinel errors with actual error values - Updated changelog to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/cloudapi/cloudapiserver/server.go | Initialized sentinel error variables with errors.New() to fix nil error checking |
| CHANGELOG.md | Added entry documenting the crash fix in version 6.7.18 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
glimberea
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this fix or implement?
Fix boot device selection crash by providing a value for the error sentinel. With the previous version, the
errwasniland this condition:Was not met, even when the server didn't exist.
Other observations:
ErrSuspendCubeLastalso, but this is rather used as a signal instead of an actual error, maybe this is not the right approach for this but redesigning it it's out of the scope of this PRChecklist
feat:/fix:/doc:/test:/refactor:)