feat: Add attribute in order to fetch user data for groups only when …#880
Merged
adeatcu-ionos merged 5 commits intomasterfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an optional get_users_data attribute to control whether user information is fetched and stored in state for group resources and data sources. This optimization allows users to skip expensive user data fetching operations when that information isn't needed.
Key changes:
- Added a new boolean attribute
get_users_datawith a default value oftrueto maintain backward compatibility - Implemented schema versioning and state upgraders to ensure smooth migration for existing resources
- Modified data fetching logic to conditionally retrieve user information based on the new attribute
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| utils/constant/constants.go | Defines the default value constant for the new get_users_data attribute |
| ionoscloud/resource_group.go | Implements the core feature with schema changes, state migration logic, and conditional user data fetching |
| ionoscloud/data_source_group.go | Adds the get_users_data attribute to the group data source with schema versioning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adeatcu-ionos
force-pushed
the
change-get-users-behavior-for-group-resource
branch
from
b7d0ade to
d3dfebb
Compare
cristiGuranIonos
previously approved these changes
Oct 21, 2025
adeatcu-ionos
force-pushed
the
change-get-users-behavior-for-group-resource
branch
from
f40d1b8 to
8c6ec14
Compare
|
cristiGuranIonos
approved these changes
Oct 21, 2025
adeatcu-ionos
deleted the
change-get-users-behavior-for-group-resource
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…needed
What does this fix or implement?
The PR was created to review the functionality faster, the documentation & tests are not written yet.
Checklist
feat:/fix:/doc:/test:/refactor:)