fix(): export ionicons.json in package exports #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdlabo
added a commit
to rdlabo-team/ionic-angular-collect-icons
that referenced
this pull request
Jun 2, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
./dist/ionicons.jsonto the package exports map to allow consumers to import the JSON file directly. This is useful for tools or libraries that rely on the raw icon metadata.Without this, importing
ionicons/dist/ionicons.jsonthrows anERR_PACKAGE_PATH_NOT_EXPORTEDerror due to the "exports" field restrictions.This update ensures compatibility with modern module resolution and prevents runtime errors when accessing this file.