Skip to content

feat(ios)!: emit CAPBridgeViewController notifications #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcesarmobile merged 3 commits into from
Nov 10, 2025
+10 −12
Merged

feat(ios)!: emit CAPBridgeViewController notifications #8211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c09ae5
feat(ios)!: emit CAPBridgeViewController notifications
jcesarmobile Nov 5, 2025
f843cf6
Merge branch 'main' into RMET-4562
jcesarmobile Nov 6, 2025
d111dc7
Merge branch 'main' into RMET-4562
jcesarmobile Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions ios/Capacitor/Capacitor/CAPBridgeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,7 @@ import Cordova
return false
}()

// TODO: Remove in Capacitor 8 after moving status bar plugin extensions code
@objc func handleViewDidAppear() {
if bridge?.config.hasInitialFocus ?? true {
self.webView?.becomeFirstResponder()
}
}

deinit {
NotificationCenter.default.removeObserver(self)
}

override public final func loadView() {
NotificationCenter.default.addObserver(self, selector: #selector(self.handleViewDidAppear), name: Notification.Name(rawValue: "CapacitorViewDidAppear"), object: nil)
// load the configuration and set the logging flag
let configDescriptor = instanceDescriptor()
let configuration = InstanceConfiguration(with: configDescriptor, isDebug: CapacitorBridge.isDevEnvironment)
Expand Down Expand Up @@ -76,11 +64,17 @@ import Cordova

override open func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)
NotificationCenter.default.post(Notification(name: .capacitorViewDidAppear))
if bridge?.config.hasInitialFocus ?? true {
self.webView?.becomeFirstResponder()
}
}

override open func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
super.viewWillTransition(to: size, with: coordinator)
NotificationCenter.default.post(Notification(name: .capacitorViewWillTransition))
}

override open func canPerformUnwindSegueAction(_ action: Selector, from fromViewController: UIViewController, withSender sender: Any) -> Bool {
return false
}
Expand Down
4 changes: 4 additions & 0 deletions ios/Capacitor/Capacitor/CAPNotifications.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ extension Notification.Name {
public static let capacitorDecidePolicyForNavigationAction =
Notification.Name(rawValue: "CapacitorDecidePolicyForNavigationActionNotification")
public static let capacitorStatusBarTapped = Notification.Name(rawValue: "CapacitorStatusBarTappedNotification")
public static let capacitorViewDidAppear = Notification.Name(rawValue: "CapacitorViewDidAppear")
public static let capacitorViewWillTransition = Notification.Name(rawValue: "CapacitorViewWillTransition")
}

@objc extension NSNotification {
Expand All @@ -26,6 +28,8 @@ extension Notification.Name {
public static let capacitorDidFailToRegisterForRemoteNotifications = Notification.Name.capacitorDidFailToRegisterForRemoteNotifications
public static let capacitorDecidePolicyForNavigationAction = Notification.Name.capacitorDecidePolicyForNavigationAction
public static let capacitorStatusBarTapped = Notification.Name.capacitorStatusBarTapped
public static let capacitorViewDidAppear = Notification.Name.capacitorViewDidAppear
public static let capacitorViewWillTransition = Notification.Name.capacitorViewWillTransition
}

/**
Expand Down