-
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: typo #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo #2221
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying vue-i18n-next with
|
Latest commit: |
62b6b1d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9d1f55bb.vue-i18n-next.pages.dev |
Branch Preview URL: | https://fix-core-base-typo.vue-i18n-next.pages.dev |
@intlify/core
@intlify/core-base
@intlify/devtools-types
@intlify/message-compiler
petite-vue-i18n
@intlify/shared
vue-i18n
@intlify/vue-i18n-core
commit: |
@kazupon It is nice that it was fixed, but it caused this issue: |
@kazupon This looks like a breaking changes, other package that using core-base will also need to update the imports and limit the version of core-base to ^11.1.8. or we can have a alias for the old consistent to make sure backward compatibility. I just notice that when I do package update, I got this error:
|
Sorry, I overlooked that point. |
Thanks to AI, we have just found out the typo.
we have not noticed the typo for 5 years, so far 😂
I noticed this while working on a side project.
kazupon/gunshi@08111f8#diff-dc06d3cebbf88f0f86a5b8eefba8c4a2e349130eec7d1af4b69ecfbe3ffb909cR377