Skip to content

Capture compiler stderr in FindSYCLToolkit.cmake #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Capture compiler stderr in FindSYCLToolkit.cmake #1889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/Modules/FindSYCLToolkit.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ function(SYCL_CMPLR_TEST_BUILD error TEST_SRC_FILE TEST_EXE)
${TEST_EXE}
WORKING_DIRECTORY ${SYCL_CMPLR_TEST_DIR}
OUTPUT_VARIABLE output ERROR_VARIABLE output
ERROR_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log
OUTPUT_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log
Comment on lines +118 to 119
Copy link
Preview

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The ERROR_FILE parameter should be placed before OUTPUT_FILE to follow CMake's conventional parameter ordering in execute_process commands.

Suggested change
ERROR_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log
OUTPUT_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log
OUTPUT_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log
ERROR_FILE ${SYCL_CMPLR_TEST_DIR}/Compile.log

Copilot uses AI. Check for mistakes.

RESULT_VARIABLE result
TIMEOUT 60
Expand Down
Loading