remove scaled_mm fallback #1746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "_scaled_mm" fallback registration from the XPU backend, addressing duplicate registration issues as detailed in the PR description.
- Remove the "_scaled_mm" fallback entry to prevent duplicate registrations
- Align the XPU fallback registration with the updates in PyTorch core
|
Hi, let's file a separate PR to a temp branch such as We do these things to avoid breaking CI both at PyTorch and torch-xpu-ops. |
guangyey
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
LGTM.
Let's merge this PR after pytorch/pytorch#140972 landed in case block internal CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaled_mm has supported in pytorch pytorch/pytorch#140972
This fallback will cause duplicate registration.
remove this fallback after pytorch/pytorch#140972 merged