[CI] Enable UR runs in benchmarking CI #19753
Merged
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Aug 11, 2025
| # intermediate files required can be stitched together from the build files. | ||
| # However, this is not exactly "clean" or "fun to maintain"... | ||
| - name: Build Unified Runtime | ||
| shell: bash |
There was a problem hiding this comment.
This isn't run by default in precommit or postcommit right?
There was a problem hiding this comment.
Nope, this workflow is completely separate from precommit/postcommit.
If we were to do this in precommit in the future, this solution would not suffice. I proposed in the comments that we have UR build workflows produce an UR artifact, but that would involve reorganizing the UR workflows.
|
@intel/llvm-gatekeepers PR is ready, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary change enabling UR benchmarking.
This is not the most ideal solution, but currently no benchmarking data is being collected for the UR; this data is needed urgently. A proper solution can be discussed after UR benchmarking has been re-enabled.
Note: The new benchmark CI runs are using a docker environment, there seems to be a very consistent performance penalty of 2 microseconds as a result compared to previous UR benchmark CI runs that are not using a docker environment. Please see https://intel.github.io/llvm/benchmarks/?tags=UR&runs=Baseline_PVC_L0%2CCommit5661e7275b64a6c00a96ae295815f40a9384e958_PVC_L0 : this compares performance of latest commit with commit 5661e72, which was the commit used to benchmark the last run result from July 30th.
I am currently looking into ways to reduce this penalty, for now I am opening this PR as the data is still useful. It's worth noting that SYCL only incurred 0.5-1 microsecond penalty from this move, so there may be room for improvement here.