Skip to content

[UR][CUDA] Properly quote strings in CMake #19750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[UR][CUDA] Properly quote strings in CMake #19750

merged 1 commit into from
Aug 11, 2025

Conversation

al42and
Copy link
Contributor

@al42and al42and commented Aug 8, 2025

CUDAToolkit_INCLUDE_DIRS is a ;-list

@al42and
[UR][CUDA] Properly quote strings in CMake
a611d9a 
CUDAToolkit_INCLUDE_DIRS is a ;-list
@al42and al42and requested review from a team as code owners August 8, 2025 14:23
@al42and al42and requested a review from omarahmed1111 August 8, 2025 14:23
npmiller
npmiller approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@npmiller
Copy link
Contributor

@intel/llvm-gatekeepers this is ready to merge

@kbenzie kbenzie merged commit 3c2678c into intel:sycl Aug 11, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmiller npmiller npmiller approved these changes

@aarongreig aarongreig aarongreig approved these changes

@omarahmed1111 omarahmed1111 Awaiting requested review from omarahmed1111 omarahmed1111 is a code owner automatically assigned from intel/llvm-reviewers-cuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al42and @npmiller @aarongreig @kbenzie