Skip to content

[Inline] Enable constant folding for fpbuiltin sqrt #19746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Conversation

bader
Copy link
Contributor

@bader bader commented Aug 7, 2025

Constant folding should meet any accuracy requirements enforceby the
fpbuiltin intrinsic as it provides correctly-rounded implementation.

Constant folding should meet any accuracy requirements enforceby the
fpbuiltin intrinsic as it provides correctly-rounded implementation.
@bader bader requested a review from a team as a code owner August 7, 2025 22:46
@bader bader temporarily deployed to WindowsCILock August 7, 2025 22:46 — with GitHub Actions Inactive
@bader bader requested a review from jcranmer-intel August 7, 2025 22:46
@bader bader temporarily deployed to WindowsCILock August 7, 2025 23:22 — with GitHub Actions Inactive
@bader bader temporarily deployed to WindowsCILock August 7, 2025 23:22 — with GitHub Actions Inactive
@bader
Copy link
Contributor Author

bader commented Aug 8, 2025

@intel/dpcpp-devops-reviewers, I see a new check. It fails on:

Failed Tests (1):
  SYCL :: MemorySanitizer/track-origins/check_host_usm.cpp

Is this the same issue as reported in #19585 or something new?

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a coding style nit.

@bader bader temporarily deployed to WindowsCILock August 8, 2025 14:51 — with GitHub Actions Inactive
Copy link
Contributor

@jcranmer-intel jcranmer-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably a few more places that fpbuiltin.sqrt can be considered equivalent to for optimizations, but these are the most important (and the only ones involved in constant folding, fwiw).

@bader bader temporarily deployed to WindowsCILock August 8, 2025 15:47 — with GitHub Actions Inactive
@bader bader temporarily deployed to WindowsCILock August 8, 2025 15:47 — with GitHub Actions Inactive
@bader bader merged commit 367d5c1 into intel:sycl Aug 8, 2025
27 checks passed
@bader bader deleted the sqrt-opt branch August 8, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants