[SYCL][DOC] Add design document for SYCL-RTC #19698
Open
+312
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <[email protected]>
|
@intel/dpcpp-doc-reviewers @intel/dpcpp-devops-reviewers The workflow to generate documentation seems to be broken due to a dependency version mismatch: https://github.com/intel/llvm/actions/runs/16728105137/job/47349068323?pr=19698 |
sommerlukas
reviewed
Aug 5, 2025
Comment on lines
+301
to
+304
| At the moment, the support is available in [daily | ||
| builds](https://github.com/intel/llvm/releases) of the open-source version of | ||
| DPC++. | ||
|
|
There was a problem hiding this comment.
Suggested change
| At the moment, the support is available in [daily | |
| builds](https://github.com/intel/llvm/releases) of the open-source version of | |
| DPC++. |
This is prone to be outdated, better to remove it.
| code module into smaller units (either as requested by the user, or required by | ||
| the ESIMD mode), and to compute the properties that need to be passed to the | ||
| SYCL runtime when the device images are loaded. | ||
|
|
There was a problem hiding this comment.
We could mention the code duplication and the plans to remove it in the future here.
aelovikov-intel
approved these changes
Aug 5, 2025
Comment on lines
+227
to
+229
| *preprocessed* source string, i.e. with all `#include` directives resolved. We | ||
| additionally compute a hash value of the rendered command-line arguments, and | ||
| append it to the hash of the preprocessed source to obtain the final cache key. |
There was a problem hiding this comment.
I'd expect clang's PCH to have to deal with the same issue. Have you looked into re-using that infrastructure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.