[SYCL][NFC] Refactor common helpers #19044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dropped barely used `__SYCL_ASSERT` macro - Moved `__SYCL_UR_ERROR_REPORT` macro and corresponding helper function to library - Moved helpers thare are used in a single header to that header to reduce their impact on other headers
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bader
reviewed
Jun 18, 2025
Comment on lines
+116
to
+117
|
|
||
|
|
| #include <sycl/detail/common.hpp> // for NDLoop, __SYCL_ASSERT | ||
| #include <sycl/__spirv/spirv_types.hpp> // for Scope, __ocl_event_t | ||
| #include <sycl/access/access.hpp> // for decorated, mode, addr... | ||
| #include <sycl/detail/common.hpp> |
There was a problem hiding this comment.
Is this #include used by group.hpp?
| @@ -59,6 +59,29 @@ class custom_selector : public device_selector { | |||
| } | |||
| }; | |||
|
|
|||
| inline std::string_view get_backend_name_no_vendor(backend Backend) { | |||
There was a problem hiding this comment.
I think the idea of having this function in DPC++ headers is to make sure that sycl-ls prints the same values as DPC++ runtime uses for the env. variables. Now, we need to make sure that they are in sync. How do we do that?
Can we move this function to separate "public" header, which is not included by sycl.hpp, but included by DPC++ runtime and sycl-ls tool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__SYCL_ASSERTmacro__SYCL_UR_ERROR_REPORTmacro and corresponding helper function to library