[SYCL][NFC] Extract specialization constant's processing from sycl-post-link to SYCLPostLink library. #19022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-link to SYCLPostLink library. This change allows later reuse in the New Offloading Model and sycl-jit.
|
The interface of a function SmallVector<ModuleDesc> MDs;
Modified |= handleSpecializationConstants(MDs, Mode);If you have a better alternative for the function's interface let me know. |
| @@ -0,0 +1,97 @@ | |||
| //= SpecializationConstants.h - Processing of SYCL Specialization Constants ==// | |||
There was a problem hiding this comment.
Suggested change
| //= SpecializationConstants.h - Processing of SYCL Specialization Constants ==// | |
| //= SpecializationConstants.cpp - Processing of SYCL Specialization Constants ==// |
| std::optional<SpecConstantsPass::HandlingMode> Mode, | ||
| bool GenerateModuleDescWithDefaultSpecConsts, | ||
| SmallVectorImpl<module_split::ModuleDesc> *NewModuleDescs) { | ||
| assert((GenerateModuleDescWithDefaultSpecConsts ^ !NewModuleDescs) && |
There was a problem hiding this comment.
This is quite difficult to read. Could we rewrite this to something simpler?
Maybe something like:
Suggested change
| assert((GenerateModuleDescWithDefaultSpecConsts ^ !NewModuleDescs) && | |
| #ifdef NDEBUG | |
| if (GenerateModuleDescWithDefaultSpecConsts) | |
| assert(NewModuleDescs); | |
| #endif |
| } // namespace | ||
|
|
||
| bool llvm::sycl::handleSpecializationConstants( | ||
| SmallVectorImpl<module_split::ModuleDesc> &MDs, |
There was a problem hiding this comment.
Suggested change
| SmallVectorImpl<module_split::ModuleDesc> &MDs, | |
| const SmallVectorImpl<module_split::ModuleDesc> &MDs, |
| MAM.registerPass([&] { return PassInstrumentationAnalysis(); }); | ||
| RunSpecConst.addPass(std::move(SCP)); | ||
|
|
||
| // Perform the spec constant intrinsics transformation on resulting module |
There was a problem hiding this comment.
Suggested change
| // Perform the spec constant intrinsics transformation on resulting module | |
| // Perform the spec constant intrinsics transformation on resulting module. |
| ModulePassManager RunSpecConst; | ||
| ModuleAnalysisManager MAM; | ||
| SpecConstantsPass SCP(Mode); | ||
| // Register required analysis |
There was a problem hiding this comment.
Suggested change
| // Register required analysis | |
| // Register required analysis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows later reuse of specialization constant's processing in the New Offloading Model and sycl-jit.