fix: drop location handling #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
drop-find_product_location
branch
from
980ea99 to
2d78947
Compare
ffontaine
force-pushed
the
drop-find_product_location
branch
5 times, most recently
from
05bb229 to
ee399fa
Compare
Drop find_product_location as it tries to find the location of the product on the system parsing the SBOM which obviously doesn't make sense While at it, drop location totally from ProductInfo. Indeed, currently only the first location of the product is saved in the SBOM. Instead of using this location field, set the evidence to be the list of paths saved in all_cve_data. This will avoid to duplicate information. __identity_members, __eq__ and __hash__, which were added by commit f1d3c75 to handle location, are kept to still handle the optional purl parameter and avoid breaking test_product_info_{equality,hashing} tests. Fix intel#4676 Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
force-pushed
the
drop-find_product_location
branch
from
ee399fa to
e56e94c
Compare
terriko
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
find_product_locationas it tries to find the location of the product on the system parsing the SBOM which obviously doesn't make senseWhile at it, drop location totally from
ProductInfo. Indeed, currently only the first location of the product is saved in the SBOM. Instead of using this location field, set the evidence to be the list of paths saved inall_cve_data. This will avoid to duplicate information.__identity_members,__eq__and__hash__, which were added by commit f1d3c75 to handle location, are kept to still handle the optional purl parameter and avoid breakingtest_product_info_{equality,hashing}tests.Fix #4676