Skip to content

Conversation

jananir640
Copy link
Contributor

Fixes this issue: #4003

The current tool is not able to detect python3.11 on a python3 DLL file due to the fact that its version pattern does not match any existing pattern in checkers/python.py. I added r"tags/v([23]+\.[0-9]+\.[0-9]+)\r?\nversion_info" as a version pattern since this is the unique way that the DLL displays the python version.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (d6cbe40) to head (d87d887).
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4023      +/-   ##
==========================================
+ Coverage   75.41%   80.45%   +5.04%     
==========================================
  Files         808      820      +12     
  Lines       11983    12567     +584     
  Branches     1598     1950     +352     
==========================================
+ Hits         9037    10111    +1074     
+ Misses       2593     2042     -551     
- Partials      353      414      +61     
Flag Coverage Δ
longtests 79.98% <ø> (+4.57%) ⬆️
win-longtests 78.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm glad you were able to find a pattern that works for this.

It might be nice to have a test for this, but I'll file a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants