Skip to content

Conversation

Mayankrai449
Copy link
Contributor

@Mayankrai449 Mayankrai449 commented Dec 19, 2023

This pull request makes the following changes:

  • Replaced 'tagvalue' by 'tag' as it was not supported by '--sbom-format' argument.
  • Added an argument '.' after 'sbom.spdx' to specify directory for scanning.

@terriko terriko changed the title Updated examples in sbom_generation.md docs: Updated examples in sbom_generation.md Dec 19, 2023
@terriko
Copy link
Contributor

terriko commented Dec 19, 2023

Thanks for spotting and fixing this one, @Mayankrai449 ! I've approved the tests to run and will hopefully be back once they're done.

@Mayankrai449
Copy link
Contributor Author

@terriko it needs to be approved again after branch update.

@terriko
Copy link
Contributor

terriko commented Dec 19, 2023

Running again!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're ready to merge. Thank you again and congrats on your first commit with us!

@terriko terriko merged commit 3dc347e into intel:main Dec 19, 2023
@Mayankrai449 Mayankrai449 deleted the mayankrai/issue3637 branch December 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Correct examples for sbom generation in readme
2 participants