Skip to content

Conversation

rhythmrx9
Copy link
Contributor

closes #1607

@codecov-commenter
Copy link

Codecov Report

Merging #1609 (fffcdae) into main (67be450) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   81.64%   81.46%   -0.18%     
==========================================
  Files         290      290              
  Lines        5790     5790              
  Branches      953      953              
==========================================
- Hits         4727     4717      -10     
- Misses        842      851       +9     
- Partials      221      222       +1     
Flag Coverage Δ
longtests 81.46% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_cvedb.py 58.53% <100.00%> (ø)
cve_bin_tool/nvd_api.py 75.00% <0.00%> (-9.49%) ⬇️
cve_bin_tool/cli.py 70.17% <0.00%> (+0.43%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do feel free to leave the really easy bugs like this one for other beginners going forwards, though. I think you've now got enough experience that you don't need them and I know we've got a few people still working on those first commits so that their pull requests don't need repeated manual intervention!

@terriko terriko merged commit f938646 into intel:main Mar 22, 2022
@rhythmrx9
Copy link
Contributor Author

Just had some free time, so did this quick change. You're right, will leave issues like this for new contributors.

@rhythmrx9 rhythmrx9 deleted the disable branch March 23, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestCVEDB.test_01_nist_scrape should be disabled even in LONG_TESTS
3 participants