Skip to content

fix: tests for test_helper_script #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2021
Merged

fix: tests for test_helper_script #1255

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd830a8
fix: tests for test_helper_Script
peb-peb Jul 16, 2021
c48f3de
refactor: tests for helper-script
peb-peb Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions test/test_helper_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Copyright (C) 2021 Intel Corporation
# SPDX-License-Identifier: GPL-3.0-or-later

from re import UNICODE

import pytest

from cve_bin_tool.error_handler import UnknownArchiveType
Expand All @@ -11,41 +9,49 @@

class TestHelperScript:
@pytest.mark.parametrize(
"filename, product_name",
"filename, product_name, version_name",
[
(
"libsndfile-1.0.25-12.el7.x86_64.rpm",
"libsndfile",
"1.0.25",
), # normal packages (with 2 '-')
(
"libsndfile-1.0.31-1-aarch64.pkg.tar.xz",
"libsndfile",
"1.0.31",
), # .tar.xz packages (with 3 '-')
(
"logrotate_3.14.0-4ubuntu5_amd64.deb",
"logrotate",
"3.14.0-4ubuntu5",
), # .deb packages (with 2 '_')
(
"libarchive_3.4.2-1_aarch64_cortex-a72.ipk",
"libarchive",
"3.4.2-1",
), # .ipk packages (with 3 '_')
(
"tomcat9_9.0.37-3_all.deb",
"tomcat9",
"9.0.37-3",
), # packages with digits in product_name
(
"openssh-client_8.4p1-5ubuntu1_amd64.deb",
"openssh-client",
"8.4p1-5ubuntu1",
), # packages with '-' in product_name
(
"./Packages/bash-4.2.46-34.el7.x86_64.rpm",
"bash",
"4.2.46",
), # directaory names
],
)
def test_parse_filename(self, filename, product_name):
def test_parse_filename(self, filename, product_name, version_name):
hs = HelperScript(filename)
assert hs.parse_filename(filename) == product_name
product, version = hs.parse_filename(filename)
assert product == product_name and version == version_name

# @pytest.mark.parametrize("filename", [
# "bash-4.2.46-34.el7.x86_64.abc" # unsupported file type
Expand Down