Skip to content

Conversation

peb-peb
Copy link
Contributor

@peb-peb peb-peb commented Jul 10, 2021

why are the tests not passing? By manually looking at the files, the strings are present. Here is the output from helper script:

(venv39_CVE_Binary_tool) peb@LAPTOP-M375SCBF:/mnt/c/Users/harsh/Downloads$ python3 /mnt/d/git_stuff/cve-bin-tool/cve_bin_tool/helper_script.py libbpg-0.9.8-alt1_1.x86_64.rpm
─────────────────────────────────────────────────────────── LibbpgChecker ───────────────────────────────────────────────────────────
CONTAIN_PATTERNS = [
]
FILENAME_PATTERNS = [
        r"bpgenc",
]
VERSION_PATTERNS = [
        r"/usr/src/RPM/BUILD/libbpg-0.9.8/jctvc/TLibCommon/TComSlice.h",
        r"/usr/src/RPM/BUILD/libbpg-0.9.8/jctvc/TLibCommon/SEI.h",
        r"/usr/src/RPM/BUILD/libbpg-0.9.8/jctvc/TLibCommon/TComYuv.h",
        r"/usr/src/RPM/BUILD/libbpg-0.9.8/jctvc/TLibCommon/ContextModel3DBuffer.h",
]
VENDOR_PRODUCT = [('libbpg_project', 'libbpg')]
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (0a5fdc3) to head (17e4645).
Report is 2541 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   76.67%   78.38%   +1.71%     
==========================================
  Files         223      225       +2     
  Lines        4368     4377       +9     
  Branches      549      549              
==========================================
+ Hits         3349     3431      +82     
+ Misses        875      811      -64     
+ Partials      144      135       -9     
Flag Coverage Δ
longtests 78.38% <100.00%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BreadGenie
Copy link
Contributor

BreadGenie commented Jul 11, 2021

@peb-peb the /s and the periods in the strings need to be escaped with a \.

@peb-peb peb-peb changed the title feat(checker): libbpg checker (failing) feat(checker): libbpg checker Jul 11, 2021
@peb-peb peb-peb mentioned this pull request Jul 12, 2021
12 tasks
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, all of those version patterns look distinctly like pathnames. Does this work on other distro packages or just the one rpm? (It's mergeable either way, but we may want to flag it as being distro-specific the way we did with polarssl)

@peb-peb
Copy link
Contributor Author

peb-peb commented Jul 14, 2021

I was only able to find it for 2 distros (i.e. alt linux and netbsd) from https://pkgs.org/search/?q=libbpg. The pattern was consistent in these two.

@terriko
Copy link
Contributor

terriko commented Jul 14, 2021

Good enough for me. Let's merge it and if it turns out to be a problem, we can always adjust it later.

@terriko terriko merged commit d291d2d into intel:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants